-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit test for Paste source from M365 Apps #1918
Conversation
editor.paste(clipboardData); | ||
|
||
expect(editor.getContent()).toEqual( | ||
Browser.isFirefox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why Firefox can generate different HTML than others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about it. I think that is how Firefox handles the HTML. It seems they add family name style to paragraph element. That is the only difference I see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also verify the content model inside? Then we may understand why they are different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the content model tests to the new package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just going to check whether the function that process the content was called.
We already have other unit tests to make sure the content is sanitized correctly. These unit tests will just make sure we do not break the logic to call the function.
…u/bvalverde/addUnitTest
Add unit test using clipboard data from M365 Apps.